[AN] feat: 채팅 폴링 구현 #764
Open
[AN] feat: 채팅 폴링 구현 #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaeun5744
requested review from
dpcks0509,
jinuemong and
junjange
as code owners
gaeun5744
force-pushed
the
feat/chat-polling
branch
from
caaaa6e to
a2c2f41
Compare
gaeun5744
commented
Dec 16, 2024
Comment on lines
+10
to
+11
| val recentMessage: String?, | ||
| val recentMessageCreatedAt: LocalDateTime?, |
There was a problem hiding this comment.
채팅방 입실/퇴실일 경우 null이 들어옵니다!
junjange
approved these changes
Dec 18, 2024
Comment on lines
+29
to
+30
| override fun onHiddenChanged(hidden: Boolean) { | ||
| super.onHiddenChanged(hidden) |
There was a problem hiding this comment.
해당 메서드는 어떤 역할을 하고, 로직도 설명해주면 좋을 것 같아요
There was a problem hiding this comment.
불필요한 업데이트를 방지하고자, MainActivity에서 show를 할 때만 폴링을 진행하는 로직입니다!
| _chats.value = room.chatRooms.map { it.toUiModel() } | ||
| memberId = room.myMemberId | ||
| } | ||
| delay(1000) |
There was a problem hiding this comment.
폴링 주기를 생각했을 때, 1초가 너무 느리지 않은 적당한 업데이트 주기라고 판단했습니다.
|
좋네요~!! |
jinuemong
approved these changes
Dec 21, 2024
Comment on lines
+10
to
+11
| val recentMessage: String?, | ||
| val recentMessageCreatedAt: LocalDateTime?, |
dpcks0509
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
개발 사항