Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shipping labels] Use backend data for saved packages #14517

Merged
merged 54 commits into from
Dec 3, 2024

Conversation

bozidarsevo
Copy link
Contributor

@bozidarsevo bozidarsevo commented Nov 26, 2024

#14506

Description

Testing information

  • Install and set up the Woo Shipping extension on your store.
  • Build and run the app with the revampedShippingLabelCreation feature flag enabled.
  • Create an order with the processing status and at least one physical product.
  • In the order details, select "Create Shipping Label."
  • Store options will start fetching from backend in the background.
  • Tap "Select a Package" button
  • Switch to "Saved" tab and check that are saved packages in the list, if there are none, be sure to add at least 1 custom package in the "custom" tab in the app or on web

Screenshots

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-27.at.14.08.34.mp4

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@bozidarsevo bozidarsevo added the feature: shipping labels Related to creating, ordering, or printing shipping labels. label Nov 26, 2024
@bozidarsevo bozidarsevo changed the title [Shipping labels] Use backend list of saved packages [Shipping labels] Use backend data for saved packages Nov 26, 2024
@bozidarsevo bozidarsevo added this to the 21.3 milestone Nov 26, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 26, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14517-848163d
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commit848163d
App Center BuildWooCommerce - Prototype Builds #11949
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@bozidarsevo bozidarsevo changed the base branch from trunk to issue/14484-account-settings-for-UI-custom-packages November 26, 2024 10:36
@bozidarsevo bozidarsevo marked this pull request as ready for review December 2, 2024 12:51
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

Base automatically changed from issue/14484-account-settings-for-UI-custom-packages to trunk December 2, 2024 17:39
@bozidarsevo bozidarsevo merged commit 29dd92c into trunk Dec 3, 2024
14 checks passed
@bozidarsevo bozidarsevo deleted the issue/14506-Use-backend-list-of-packages branch December 3, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: shipping labels Related to creating, ordering, or printing shipping labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants