Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] Architecture improvements: minor updates #14582

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

joshheald
Copy link
Contributor

@joshheald joshheald commented Dec 2, 2024

Closes: #14405
Closes: #14563

Description

This PR addresses a couple of minor changes left from previous PRs.

There is no change in behaviour. Unit tests should pass, and the POS should continue to work as it did before.

Testing information

Areas to test:
Clear button should be available when viewing the item list with something in the cart. It should not be shown when the cart is empty, or when viewing checkout.

Editing the order should work as it did before: i.e. moving to the checkout without making any changes since the last time you viewed checkout should not result in the order being updated. If you go back and make changes, the next time you tap check out the order should be re-synced.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

@joshheald joshheald added type: task An internally driven task. feature: POS labels Dec 2, 2024
@joshheald joshheald added this to the 21.3 milestone Dec 2, 2024
@joshheald joshheald changed the base branch from trunk to issue/14531-separate-posItem-from-product December 2, 2024 16:35
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 2, 2024

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@joshheald joshheald marked this pull request as ready for review December 2, 2024 16:40
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 2, 2024

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr14582-93d037d
Version21.2
Bundle IDcom.automattic.alpha.woocommerce
Commit93d037d
App Center BuildWooCommerce - Prototype Builds #11916
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Base automatically changed from issue/14531-separate-posItem-from-product to trunk December 2, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
3 participants