Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Woo POS] Improve Hashable and Equatable conformance for OrderSyncProductInput.ProductType #14563

Closed
joshheald opened this issue Nov 29, 2024 · 1 comment · Fixed by #14582
Closed

[Woo POS] Improve Hashable and Equatable conformance for OrderSyncProductInput.ProductType #14563

joshheald opened this issue Nov 29, 2024 · 1 comment · Fixed by #14582
Assignees
@joshheald
Labels
feature: POS type: task An internally driven task.

Comments

@joshheald
Copy link
Contributor 

          These need work, and tests. At the moment, they're only used for grouping the OrderItems correctly, using the dictionary functions, in `createGroupedOrderSyncProductInputs`. I'll tackle this in the variations project.

Originally posted by @joshheald in #14562 (comment)
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 29, 2024 •
edited
Loading

Thanks for reporting! 👍

@joshheald joshheald self-assigned this Nov 29, 2024
@joshheald joshheald added type: task An internally driven task. feature: POS labels Nov 29, 2024
@joshheald joshheald mentioned this issue Dec 2, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshheald joshheald

Labels
feature: POS type: task An internally driven task.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Woo POS] Architecture improvements: minor updates woocommerce/woocommerce-ios
2 participants
@joshheald @dangermattic