Migrate to Spark 3's DataSource v2 interfaces #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows this library to run against various Spark 3.x versions (tested against 3.3.x and 3.5.x using assemblies generated using this branch). Prior to updating the interfaces, I refreshed the dependencies (including migrating from Spark 2.11 to 2.12) and addressed deprecations (excepting
sbt's changes to how integration tests are defined).useLocalworks in a cluster environment, but I'm unable to read PBFs larger than the includedsample.pbf(e.g., Geofabrik extracts) from S3 directly: it begins to read the remote object, but the resulting DataFrame contains 0 rows. I suspect that this is due to howparallelpbfhandles Hadoop'sFSDataInputStream, potentially across multiple threads, but I've been unable to locate the source of the problem.I'd like to share this as-is to accelerate any potential efforts by others while recognizing that there is still work to be done.
Fixes #3.