Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit 'type=text/javascript' attribute in html script tag #1020

Open
sal-bock opened this issue Nov 5, 2024 · 1 comment
Open

Omit 'type=text/javascript' attribute in html script tag #1020

sal-bock opened this issue Nov 5, 2024 · 1 comment

Comments

@sal-bock
Copy link

sal-bock commented Nov 5, 2024

Motivation:

Authors are encouraged to omit the attribute if the script refers to JavaScript code rather than specify a MIME type. The w3c validator will report warnings if we do so :-(

We should only provide the type attribute when necessary. e.g in ERXJavaScript a binding type="module", when the referenced file is a javascript module

@sal-bock
Copy link
Author

Not setting the property er.extensions.ERXResponseRewriter.javascriptTypeAttribute=true did make a lot of type attributes go away. But this property does not influence the ERXJavaScript component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant