Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom csv2bufr json mapping template in plugin configuration #758

Open
maaikelimper opened this issue Sep 4, 2024 · 5 comments
Open

custom csv2bufr json mapping template in plugin configuration #758

maaikelimper opened this issue Sep 4, 2024 · 5 comments
Assignees
Milestone

Comments

@maaikelimper
Copy link
Collaborator

Issue reported by Rodrigo from Argentina

Hello Maaike, I hope you are well.
I am contacting you because we are trying to install the version 1.b08 of W2B and we are having issues with using custom templates for csv2bufr.
We don't understand where we need to put the json mapping template:

image

The plugin configuration in the dataset editor does not currently support custom templates.

@maaikelimper maaikelimper added this to the sprint-016 milestone Sep 4, 2024
@maaikelimper maaikelimper changed the title reference custom csv2bufr json mapping template in plugin configuration custom csv2bufr json mapping template in plugin configuration Sep 4, 2024
@RoryPTB
Copy link
Contributor

RoryPTB commented Sep 4, 2024

Currently if the plugin is found in the existing dataset, the field is set to that value (DatasetEditorForm.vue, line 1551):

const populatePluginFields = (plugin) => {
            // If plugin exists, populate the fields
            if (plugin) {
                pluginIsNew.value = false;
                pluginFileExtension.value = plugin.fileType;
                pluginName.value = plugin.name;
                pluginTemplate.value = plugin.template;

This would mean the dataset was created manually with that plugin and then loaded into the dataset editor. It would be trivial to remove the template value if it doesn't fall in the hard-coded list, however I don't see why we would want to erase this information?

@maaikelimper
Copy link
Collaborator Author

Hi Rory, you are correct the user had manually created the the dataset with this plugin, and the dataset-editor correctly displayed the value and I don't think we want to erase this information.

Ideally, the DatasetEditorForm.vue should also let the user select a custom template defined in the wis2box, but I am not sure how to do this.

@david-i-berry do you have a suggestion how the dataset-editor could work with custom csv2bufr-templates ?

@david-i-berry
Copy link
Member

pygeoapi process to list templates? we already do something similar in the csv2bufr plugin.

@maaikelimper
Copy link
Collaborator Author

maaikelimper commented Sep 24, 2024

OK so resolving this issue requires the completion of 2 PRs:

  • update wis2box-api with new pygeoapi process to list available csv2bufr templates in the wis2box-instance
  • update wis2box-webapp to list templates based on the output of the new process

@david-i-berry this issue is currently assigned to you, is this ok, or should we split the work ?

@tomkralidis
Copy link
Collaborator

2024-11-21:

@alimand alimand self-assigned this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants