Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish to leaf topics only (#137) #146

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

publish to leaf topics only (#137) #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions scripts/generate-bundle.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@
if topic_to_add.startswith('/'):
topic_to_add = topic_to_add.lstrip('/')

test_parent_dir = f'{root}/{row[0]}'
if os.path.isdir(test_parent_dir):
break
topics.append(topic_to_add)

with open('topic-hierarchy/earth-system-discipline.csv', 'w') as fh:
Expand Down
2 changes: 2 additions & 0 deletions standard/requirements/core/REQ_publishing.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,6 @@
^|A |Data SHALL NOT be published with a topic that is not defined in this specification.
^|B |Data SHALL be published to at least the level of the sub-discipline topic (level 8 or beyond).
^|C |Metadata SHALL be published to at least the level of the notification type (``metadata``).
^|D |Topics SHALL be published to the lowest possible defined level (leaf).
^|E |Topics SHALL NOT be published to intermediary levels where sublevels are defined.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rows 8 and 9 are new standard practices / provisions that will lead to previously valid topics becoming invalid. I'm not sure this is suitable for the FT process.

|===
2 changes: 1 addition & 1 deletion standard/sections/clause_7_normative_text.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ The table below provides an overview of the primary topic levels.
|Seven high-level categories as defined by the WMO Unified Data Policy, Annex 1: (``atmospheric-composition``, ``climate``, ``cryosphere``, ``hydrology``, ``ocean``, ``space-weather``, or ``weather``)
|===

==== Publishing guidelines
==== Publishing

For maximum utility and efficient management of topics, it is recommended that ``data`` and ``metadata`` are published to a detailed level of the topic hierarchy. This helps avoid the "pollution" of messages under the primary topics. Note that each discipline has a sub-discipline topic named ``experimental`` for publication to provisional topics.

Expand Down
Loading