From e73c463194274b9792dbab01dfd4c9ed5494f75a Mon Sep 17 00:00:00 2001 From: Arthur Taylor Date: Wed, 20 Nov 2024 12:53:31 +0100 Subject: [PATCH] Move properties before nested selector to resolve deprecation warnings SASS has been emitting a deprecation warning because of a coming change in SASS behaviour: https://sass-lang.com/documentation/breaking-changes/mixed-decls/ In `NewLexemeForm.vue` we were using the `&` parent selector before applying additional properties to the `.wbl-snl-form` element. In this specific case, moving the parent selector after the property declarations has no effect on the semantics of the SASS or the generated CSS, and resolves the deprecation warning. Bug: T372250 --- src/components/NewLexemeForm.vue | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/NewLexemeForm.vue b/src/components/NewLexemeForm.vue index e5ff2f3b..916fb45d 100644 --- a/src/components/NewLexemeForm.vue +++ b/src/components/NewLexemeForm.vue @@ -195,10 +195,6 @@ export default { @import '@wikimedia/codex-design-tokens/theme-wikimedia-ui'; .wbl-snl-form { - & > * + * { - margin-top: var( --dimension-layout-xsmall ); - } - // Box model padding: var( --dimension-layout-small ); @@ -207,6 +203,10 @@ export default { border-width: $border-width-base; border-radius: $border-radius-base; border-color: $border-color-muted; + + & > * + * { + margin-top: var( --dimension-layout-xsmall ); + } } .wbl-snl-copyright {