From 9833d61bf88828afd9769397515776efd6ae6443 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michael=20Gro=C3=9Fe?= Date: Tue, 2 Jan 2024 16:48:27 +0100 Subject: [PATCH] Add the reason why we cannot update the Node.js version to the README I forget about every two months why exactly we cannot upgrade to a newer node version just in the GitHub actions/workflows. Better write that down right where one would expect it. --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index d0128889..df122450 100644 --- a/README.md +++ b/README.md @@ -109,6 +109,10 @@ The following dependencies should be ignored: - lint-staged: [v15.0.0](https://github.com/lint-staged/lint-staged/releases/tag/v15.0.0) drops compatibility with Node 16, which we still use in CI (see also “Prerequisites” above; Node 18 upgrade pending in [T331180](https://phabricator.wikimedia.org/T331180)). +- Node.js version: + The GitHub Workflows here should use the same Node.js version as the `mwgate-nodeXX-docker` CI job in WikibaseLexeme, + because that job builds this app for the `test:snl-distnodiff` script. + The upgrade to Node 18 there is tracked in [T331180](https://phabricator.wikimedia.org/T331180). All other dependencies should generally be updated to the latest version. If you discover that a dependency should not be updated for some reason, please add it to the above list.