Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add browser tab icon for banner dashboard #665

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Add browser tab icon for banner dashboard #665

merged 1 commit into from
Dec 20, 2024

Conversation

Sperling-0
Copy link
Contributor

@Sperling-0 Sperling-0 commented Dec 13, 2024

When many tabs are open, the banner dashboard tab gets easily lost, having a colorful emoji as a tab icon makes it easily recognisable

@Sperling-0
Copy link
Contributor Author

Note

I have chosen the greenish yellow ball as the dashboard tab icon because of its color. It's easy to spot it when many tabs are open. This (https://emojipedia.org/japanese-open-for-business-button) emoji was also in the competition, but I chose the ball because I really liked its color.
Feel free to choose something else as tab icon if you don't like it.

@Sperling-0 Sperling-0 marked this pull request as ready for review December 13, 2024 16:02
@moiikana
Copy link
Contributor

moiikana commented Dec 17, 2024

I'm not against adding a tab icon / "favicon" for the dashboard.

I only know the convention of using <link rel="icon" href="...." /> with an .ico file inside of the header though, like described in https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link.
The <link> tag describes that there are (external) resources that belong to the document (web page), like e.g. stylesheets, icons, assets,...

I suspect that browsers are optimized for this convention in the way they render things like tabs, bookmarks (wherever the icon will be appearing).
If we want to keep it professional, I'd prefer to use the link tag, but I can understand that it's "just a dashboard" that we use for ourself and you wanted to keep the change small.

@Abban
Copy link
Member

Abban commented Dec 18, 2024

You can use a png for a favicon these days too so there's no need to make a .ico. So you can grab the emoji you used and use that.

- When many tabs are open, the banner dashboard tab gets easily lost, having a colorful emoji as a tab icon makes it easily recognisable
- NVC Giraffe is the tab icon
@Sperling-0
Copy link
Contributor Author

I have added the tab icon professionally now.
NVC Giraffe is our dashboard logo!
What is NVC Giraffe?

(This is my cue to inspire you to take the NVC training :)

Feel free to replace the favicon.

@moiikana moiikana merged commit 23d7e05 into main Dec 20, 2024
1 check passed
@moiikana moiikana deleted the tab-icon branch December 20, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants