From 2c23e1ffb8e3d9c42a281e33560aa50377238a23 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thiemo=20M=C3=A4ttig?= <thiemo.maettig@wikimedia.de>
Date: Mon, 25 Apr 2016 15:42:33 +0200
Subject: [PATCH] Add TODOs to various diff(er)s and patchers

---
 src/Diff/EntityDiff.php                    | 8 ++++++++
 src/Diff/Internal/FingerprintPatcher.php   | 3 +++
 src/Diff/Internal/SiteLinkListPatcher.php  | 3 +++
 src/Diff/Internal/StatementListDiffer.php  | 2 ++
 src/Diff/Internal/StatementListPatcher.php | 3 +++
 5 files changed, 19 insertions(+)

diff --git a/src/Diff/EntityDiff.php b/src/Diff/EntityDiff.php
index 7777bfda..89071d23 100644
--- a/src/Diff/EntityDiff.php
+++ b/src/Diff/EntityDiff.php
@@ -76,6 +76,8 @@ protected function fixSubstructureDiff( array &$operations, $key ) {
 	}
 
 	/**
+	 * FIXME: Not all entities do have aliases!
+	 *
 	 * Returns a Diff object with the aliases differences.
 	 *
 	 * @return Diff
@@ -85,6 +87,8 @@ public function getAliasesDiff() {
 	}
 
 	/**
+	 * FIXME: Not all entities do have labels!
+	 *
 	 * Returns a Diff object with the labels differences.
 	 *
 	 * @return Diff
@@ -94,6 +98,8 @@ public function getLabelsDiff() {
 	}
 
 	/**
+	 * FIXME: Not all entities do have descriptions!
+	 *
 	 * Returns a Diff object with the descriptions differences.
 	 *
 	 * @return Diff
@@ -103,6 +109,8 @@ public function getDescriptionsDiff() {
 	}
 
 	/**
+	 * FIXME: Not all entities do have claims a.k.a. statements!
+	 *
 	 * Returns a Diff object with the claim differences.
 	 *
 	 * @return Diff
diff --git a/src/Diff/Internal/FingerprintPatcher.php b/src/Diff/Internal/FingerprintPatcher.php
index a8f856a2..e1c3ee26 100644
--- a/src/Diff/Internal/FingerprintPatcher.php
+++ b/src/Diff/Internal/FingerprintPatcher.php
@@ -16,6 +16,9 @@
 use Wikibase\DataModel\Term\TermList;
 
 /**
+ * TODO: Class should be public (or split, and these should be public).
+ * TODO: Should this support actual edit conflict detection?
+ *
  * Package private.
  *
  * @license GPL-2.0+
diff --git a/src/Diff/Internal/SiteLinkListPatcher.php b/src/Diff/Internal/SiteLinkListPatcher.php
index ef1bd80c..5bb762e7 100644
--- a/src/Diff/Internal/SiteLinkListPatcher.php
+++ b/src/Diff/Internal/SiteLinkListPatcher.php
@@ -10,6 +10,9 @@
 use Wikibase\DataModel\SiteLinkList;
 
 /**
+ * TODO: Class should be public.
+ * TODO: Should this support actual edit conflict detection?
+ *
  * Package private.
  *
  * @license GPL-2.0+
diff --git a/src/Diff/Internal/StatementListDiffer.php b/src/Diff/Internal/StatementListDiffer.php
index 7d855598..27dbbd15 100644
--- a/src/Diff/Internal/StatementListDiffer.php
+++ b/src/Diff/Internal/StatementListDiffer.php
@@ -9,6 +9,8 @@
 use Wikibase\DataModel\Statement\StatementList;
 
 /**
+ * TODO: Class must be public.
+ *
  * Package private.
  *
  * @since 1.0
diff --git a/src/Diff/Internal/StatementListPatcher.php b/src/Diff/Internal/StatementListPatcher.php
index cdbbd812..12eda480 100644
--- a/src/Diff/Internal/StatementListPatcher.php
+++ b/src/Diff/Internal/StatementListPatcher.php
@@ -10,6 +10,9 @@
 use Wikibase\DataModel\Statement\StatementList;
 
 /**
+ * TODO: Class must be public.
+ * TODO: Should this support actual edit conflict detection?
+ *
  * Package private.
  *
  * @since 1.0