Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON files for individual verses is both overkill and opens up technical issues. #14

Open
Lucasharskamp opened this issue Nov 21, 2024 · 0 comments

Comments

@Lucasharskamp
Copy link

Lucasharskamp commented Nov 21, 2024

You give us the following endpoint:

https://cdn.jsdelivr.net/gh/wldeh/bible-api/bibles/${version}/books/${book}/chapters/${chapter}/verses/${verse}.json

Which is nice. Problem is; there are so many of them! Each chapter has dozens of verses, there may be a ton of chapters per book, over a lot of translations. This causes millions (!) of JSON files to be created, for each and every verse. This makes maintenance hard, and I think the CDN server isn't too happy about that either. Full chapters are fine, one can simply extract the required verse(s) from there.

The result? For example, If I zipped all the files, including verses it would be 1.2GB of data. Without it, just 237MB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant