fix left facing popup buttons in scroll panels #409
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a left facing popup button is in a scroll panel, the popup will be too far to the right (and in some cases cover up the button entirely) if that panel has been scrolled at all. This is (I think) because the scroll panel calls
Popup::performLayout
but notPopupButton::performLayout
. In the PR, both functions set the anchor to the same (x) position, so that is no longer an issue.Example (based on example_icons.cpp):