Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set bind parameter in GUI installer when defining managed bitcoind config #1423

Open
jp1ac4 opened this issue Nov 1, 2024 · 3 comments
Open
Labels
Robustness Something could be made les brittle

Comments

@jp1ac4
Copy link
Collaborator

jp1ac4 commented Nov 1, 2024

It seems that bitcoind 28.0 may error if there are other instances running on the same machine and bitcoin network due to a port collision. Now that Liana's managed bitcoind has been upgraded to 28.0, we should set the bind parameter (to be confirmed) to a random port to avoid this collision.

User impact is likely to be low given that a user selecting to use managed bitcoind is not expected to be running multiple instances. A short-term workaround would be to either stop other bitcoind instances or edit the managed bitcoind config to specifiy this additional parameter.

@jp1ac4
Copy link
Collaborator Author

jp1ac4 commented Nov 1, 2024

Our approach may depend on the outcome of bitcoin/bitcoin#31133.

@nondiremanuel nondiremanuel added the Robustness Something could be made les brittle label Nov 4, 2024
@jp1ac4
Copy link
Collaborator Author

jp1ac4 commented Nov 7, 2024

See also ba553e9.

@jp1ac4
Copy link
Collaborator Author

jp1ac4 commented Nov 11, 2024

On a related note and possibly as part of this fix, the ports used by managed bitcoind could be chosen at runtime. We currently pick some available ports randomly when first installing bitcoind and save these in bitcoin.conf, but these ports might not be available the next time Liana is opened. These newly chosen values could either be passed as command-line arguments or saved to the config file in order to facilitate the use of bitcoin-cli.

Of course any ports used in the daemon config file should be fixed still :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Robustness Something could be made les brittle
Projects
None yet
Development

No branches or pull requests

2 participants