Query with object value - support Mysql and Postgres #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Idokah
changed the title
MXPOL
reviewed
Feb 6, 2024
| @@ -19,6 +19,8 @@ export default class DataProvider implements IDataProvider { | |||
| const { sortExpr } = this.filterParser.orderBy(sort) | |||
| const projectionExpr = this.filterParser.selectFieldsFor(projection) | |||
| const sql = `SELECT ${projectionExpr} FROM ${escapeIdentifier(collectionName)} ${filterExpr} ${sortExpr} OFFSET $${offset} LIMIT $${offset + 1}` | |||
| console.log({ sqlExpression: sql, parameters: [...parameters, skip, limit] }) | |||
MXPOL
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
today, we are allowing querying nested fields, but not full objects - i.e.
this wouldn't work:
{fieldName: { $eq: {someKey: "a"}}}this is working:
{fieldName.someKey: { $eq: "a"}}we need to support it in order to support filtering encrypted fields (and filtering any other object field and find by value that is an object)