Fix column type (#481)

* Fix column type in SQL schema translator * Fix column type in postgres schema translator
wix · Dec 5, 2023 · fc6ba95 · fc6ba95
1 parent 41767c0
commit fc6ba95
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/libs/external-db-mysql/src/sql_schema_translator.spec.ts b/libs/external-db-mysql/src/sql_schema_translator.spec.ts
@@ -68,7 +68,7 @@ describe('Sql Schema Column Translator', () => {
 
         describe('string fields', () => {
             test('string', () => {
-                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeId(ctx.fieldName)} VARCHAR(2048)`)
+                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeId(ctx.fieldName)} TEXT`)
             })
 
             test('string with length', () => {

diff --git a/libs/external-db-mysql/src/sql_schema_translator.ts b/libs/external-db-mysql/src/sql_schema_translator.ts
@@ -90,7 +90,7 @@ export default class SchemaColumnTranslato {
                 return 'TIMESTAMP DEFAULT CURRENT_TIMESTAMP'
 
             case 'text_string':
-                return `VARCHAR${this.parseLength(precision)}`
+                return precision ? `VARCHAR${this.parseLength(precision)}` : 'TEXT'
 
             case 'text_small':
             case 'text_language':

diff --git a/libs/external-db-postgres/src/sql_schema_translator.spec.ts b/libs/external-db-postgres/src/sql_schema_translator.spec.ts
@@ -54,7 +54,7 @@ describe('Sql Schema Column Translator', () => {
 
         describe('string fields', () => {
             test('string', () => {
-                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeIdentifier(ctx.fieldName)} varchar(2048)`)
+                expect( env.schemaTranslator.columnToDbColumnSql({ name: ctx.fieldName, type: 'text', subtype: 'string' }) ).toEqual(`${escapeIdentifier(ctx.fieldName)} text`)
             })
 
             test('string with length', () => {

diff --git a/libs/external-db-postgres/src/sql_schema_translator.ts b/libs/external-db-postgres/src/sql_schema_translator.ts
@@ -97,7 +97,7 @@ export default class SchemaColumnTranslator {
                 return 'timestamp'
 
             case 'text_string':
-                return `varchar${this.parseLength(precision)}`
+                return precision ? `varchar${this.parseLength(precision)}` : 'text'
 
             case 'text_small':
             case 'text_medium':