Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use alternative selector script #4628

Closed
wants to merge 2 commits into from
Closed

Use alternative selector script #4628

wants to merge 2 commits into from

Conversation

gosha212
Copy link
Contributor

@gosha212 gosha212 commented Nov 3, 2024

Description

  • This pull request addresses the issue described here: #<?>

In this pull request, I have …

For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@gosha212 gosha212 requested a review from d4vidi as a code owner November 3, 2024 21:47
asafkorem
asafkorem requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@asafkorem asafkorem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gosha212 is that the solution we're moving forward or we're still testing this approach?
Anyhow if it works on Android, and the same script from iOS, let's plan together how we can do that from the same source (JS level)

detox/android/detox/src/full/java/com/wix/detox/espresso/web/DetoxDriverAtoms.java Show resolved Hide resolved
@gosha212 gosha212 closed this Nov 26, 2024
@gosha212
Copy link
Contributor Author

This POC is not relevant. Couldn't make it work better that the espresso solution

@gosha212 gosha212 deleted the webview_performance branch November 26, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asafkorem asafkorem asafkorem requested changes

@d4vidi d4vidi Awaiting requested review from d4vidi d4vidi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gosha212 @asafkorem