Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Update !preview response #8872

Merged
merged 12 commits into from
Oct 20, 2023
Merged

[ci] Update !preview response #8872

merged 12 commits into from
Oct 20, 2023

Conversation

natemoo-re
Copy link
Member

Changes

  • Updates our snapshot release workflow
  • Moves away from the deprecated ::set-output to the new >> $GITHUB_OUTPUT method for passing values between job steps.
  • Hopefully fixes some formatting in the response message (but this is difficult to test)

Testing

Not sure how I can test this, tbh...

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4ef31b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Oct 19, 2023
@lilnasy
Copy link
Contributor

lilnasy commented Oct 20, 2023

Tested it by butchering my fork and there seems to be an error.
image

Found a stackoverflow thread for this but I can't make sense of it.
https://stackoverflow.com/questions/74137120/how-to-fix-or-avoid-error-unable-to-process-file-command-output-successfully

ematipico
ematipico approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

.github/workflows/snapshot-release.yml Outdated Show resolved Hide resolved
.github/workflows/snapshot-release.yml Outdated Show resolved Hide resolved
@natemoo-re natemoo-re force-pushed the chore/update-snapshot branch from 25ea3f8 to 027aefa Compare October 20, 2023 14:22
@lilnasy
Copy link
Contributor

lilnasy commented Oct 20, 2023

It works well: lilnasy#5 (comment)

There seems to be something weird going on with encoding still, and really we only care about the last 4 lines. right?

alexanderniebuhr
alexanderniebuhr approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@alexanderniebuhr alexanderniebuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Would like to see it in a shared repo soon, so we can use the same for withastro/adapters 🚀

@lilnasy
Copy link
Contributor

lilnasy commented Oct 20, 2023 •
edited
Loading

Yeah, that was it lilnasy#5 (comment)
Edit: here's experimental-- in the release tag: https://www.npmjs.com/package/testing-ci-ortsa?activeTab=versions

@natemoo-re
Copy link
Member Author

Thanks for all your help @lilnasy! Think this is working how I want now ☺️

@natemoo-re natemoo-re merged commit 144815c into main Oct 20, 2023
13 checks passed
@natemoo-re natemoo-re deleted the chore/update-snapshot branch October 20, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilnasy lilnasy lilnasy approved these changes

@alexanderniebuhr alexanderniebuhr alexanderniebuhr approved these changes

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
🚨 action Modifies GitHub Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@natemoo-re @lilnasy @ematipico @alexanderniebuhr