Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In correct type for first param in getViteConfig() #12791

Closed
1 task
ngdangtu-vn opened this issue Dec 19, 2024 · 3 comments
Closed
1 task

In correct type for first param in getViteConfig() #12791

ngdangtu-vn opened this issue Dec 19, 2024 · 3 comments
Labels
needs repro Issue needs a reproduction

Comments

@ngdangtu-vn
Copy link

Astro Info

Astro                    v5.0.9
Node                     v20.12.2
System                   Linux (x64)
Package Manager          bun
Output                   static
Adapter                  none
Integrations             none

Clipboard command not found!
Please manually copy the text above.

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

Could you guy confirm if the document and example is incomplete because when I try to add test property into the object of the first param of getViteConfig() function, I received error from vscode:

image

Here is the message:

Object literal may only specify known properties, and 'test' does not exist in type 'UserConfig'.ts(2353)

Workspace dependencies:

    "devDependencies": {
        "@types/bun": "^1.1.14",
        "@types/node": "^22.10.2",
        "tsup": "^8.3.5",
        "vitest": "^2.1.8"
    },

And I copied from the example file so this may not be a bug but more of request document improvement: https://github.com/withastro/astro/blob/latest/examples/with-vitest/vitest.config.ts

What's the expected result?

According to the document and example, it should accept test property, not firing an error.

Link to Minimal Reproducible Example

https://github.com/withastro/astro/blob/latest/examples/with-vitest/vitest.config.ts

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Dec 19, 2024
@ascorbic
Copy link
Contributor

The linked reproduction doesn't match your screenshot. Can you link a repro that matches.

@ascorbic ascorbic added the needs repro Issue needs a reproduction label Dec 20, 2024
Copy link
Contributor

Hello @ngdangtu-vn. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with needs repro will be closed if they have no activity within 3 days.

@github-actions github-actions bot removed the needs triage Issue needs to be triaged label Dec 20, 2024
@ngdangtu-vn
Copy link
Author

Nah, I give up on testing for now

@ematipico ematipico closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs repro Issue needs a reproduction
Projects
None yet
Development

No branches or pull requests

3 participants