-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update react monorepo to v19 (major) #12686
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 4e31dc9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d90ddc4
to
831d92d
Compare
a760f23
to
1144ea4
Compare
654fa1b
to
937b878
Compare
622a602
to
8099ebe
Compare
It doesn't look like React 19 is properly working in Astro yet. |
8099ebe
to
25c5473
Compare
25c5473
to
b46f764
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
The tests are failing as there's a pickle with how our tests runs and how tolerant React 19 is. In our tests, we run build and dev tests one after the other. The issue is that sometimes we import In practice I believe this is an issue for most frameworks including React 18, but they're tolerant enough that mismatching variants, e.g. |
Is this caused by the fact that we run all our tests in the same process, in one single file? Can we try with |
I don't think that would fix it. We'd have to split our build and dev tests as separate files so that each runs in their own process with their own import cache. I'm testing locally by running |
This PR contains the following updates:
^18.3.12
->^19.0.3
^18.3.1
->^19.0.2
^18.3.1
->^19.0.0
^18.3.1
->^19.0.0
Release Notes
facebook/react (react)
v19.0.0
Compare Source
facebook/react (react-dom)
v19.0.0
Compare Source
Configuration
📅 Schedule: Branch creation - "* 0-3 * * 1" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.