Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in line with latest community standards #103

Open
expede opened this issue Jan 24, 2022 · 1 comment
Open

Bring in line with latest community standards #103

expede opened this issue Jan 24, 2022 · 1 comment

Comments

@expede
Copy link
Member

expede commented Jan 24, 2022

Credo now warns by default on use of Apply.apply, and piping into anonymous functions. We should consider making these not conflict out of the box.

{Credo.Check.Readability.PipeIntoAnonymousFunctions, false},
# This rule incorrectly flags uses of Witchcraft.Semigroupoid.apply/2
{Credo.Check.Refactor.Apply, false}

See #102 (comment)

@QuinnWilton
Copy link
Member

To clarify, Credo specifically warns on cases where apply/2 is used with a list of known size. Credo argues that if you can know the number of arguments at compile time, then you should just call the function directly, with apply/2 being reserved for more dynamic uses.

I agree that finding a way to avoid this warning would be worthwhile though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants