Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout to request #87

Open
ahayamb opened this issue May 6, 2017 · 2 comments · May be fixed by #88
Open

Add timeout to request #87

ahayamb opened this issue May 6, 2017 · 2 comments · May be fixed by #88

Comments

@ahayamb
Copy link

ahayamb commented May 6, 2017 •
edited
Loading

Sometimes, adding timeout parameter/default timeout would be helpful since the requests default timeout is None which will hang the application up infinitely
http://docs.python-requests.org/en/master/user/advanced/#timeouts
@ahayamb ahayamb linked a pull request May 6, 2017 that will close this issue
Open
@zshimanchik
Copy link

+1
Sometimes api.wit.ai is not accessible, in this case request can hang for several minutes

@jackneil
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add default timeout parameter on requests ahayamb/pywit
3 participants
@ahayamb @zshimanchik @jackneil