Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark undeliverable message as tried #312

Open
thomasLeMeur opened this issue Oct 26, 2022 · 0 comments
Open

Mark undeliverable message as tried #312

thomasLeMeur opened this issue Oct 26, 2022 · 0 comments

Comments

@thomasLeMeur
Copy link

On worker OOM, Remoulade thinks message has not been tried.
So, Retries middleware won't tag it and user max_retries argument won't be respected.

Idea:
Use RabbitMQ 'redelivered' tag to handle this case.
If tag is set to True, start to count the number of tries for a given message with Redis.
If message successes, remove the Redis key.
If counter reaches a limit (max_retries value ?), raise an error

See https://www.rabbitmq.com/consumers.html#message-properties

@thomasLeMeur thomasLeMeur changed the title Catch undeliverable message as tried Mark undeliverable message as tried Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant