Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error after installing plugin #12

Open
WebVPF opened this issue Sep 3, 2021 · 8 comments
Open

Error after installing plugin #12

WebVPF opened this issue Sep 3, 2021 · 8 comments

Comments

@WebVPF
Copy link
Contributor

WebVPF commented Sep 3, 2021

After installing via composer plugin User does not install other plugins via composer.
When trying to install a new plugin, an error appears in the console, and new plugin is not installed because of this. The error refers to User plugin.

@bennothommo
Copy link
Member

@WebVPF please post the error message.

@WebVPF
Copy link
Contributor Author

WebVPF commented Sep 3, 2021

I thought it was just my problem, but I saw a comment:
cdf262f#commitcomment-55798835

@WebVPF
Copy link
Contributor Author

WebVPF commented Sep 3, 2021

@bennothommo here is a screenshot of the error:

2021-09-03_094147

@LukeTowers
Copy link
Member

@bennothommo ah, I see why this is an issue now. The packagist package itself pulled in via winter/wn-user-plugin reports that it replaces rainlab/user-plugin, but then composer-merge-plugin makes it so that the already installed winter plugin includes its replace property in the root composer.json file. Simple enough fix in theory (maybe some other edge cases though), we just tell the composer merge plugin to not merge in the replace property

@WebVPF
Copy link
Contributor Author

WebVPF commented Sep 3, 2021

The User plugin itself is installed. After installation php artisan winter: up command runs without errors.
But after that, other plugins are not installed through the composer and an error appears.

@LukeTowers
Copy link
Member

@WebVPF if you have no need of the composer-merge-plugin in your project (i.e. you don't develop plugins locally in your project with their own composer.json files), then you can just remove it entirely and that will solve your issue.

@mjauvin
Copy link
Member

mjauvin commented Jun 26, 2022

Not sure if I'm missing somthing here, but if I add the "replace" option back into the winter plugins composer files, this behavior is not triggered anymore. I can successfully install offline/oc-mall-plugin and it will honor the installed winter plugins (instead of forcing rainlab plugins). After that, I tried adding more plugins with composer and had no issue as previously described.

@mjauvin
Copy link
Member

mjauvin commented Jun 26, 2022

nah, still the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants