Hackathon/edge mesh #378

Zhouyuan-Chen · 2023-09-22T02:50:35Z

Just add dummy .hpp/.cpp and modified cmake files.

Zhouyuan-Chen · 2023-09-22T04:03:31Z

fixed compilation problems

mtao

this should probably be a PR draft. I started leaving some comments and then realized this is mostly a copy-paste of PointMesh :)

src/wmtk/EdgeMesh.cpp

daniel-zint

Looks all good so far. I did not go through the functions labeled as not tested yet. I guess the next step is to add tests and make sure all these functions do what they are supposed to do.

src/wmtk/Types.hpp

Zhouyuan-Chen · 2023-09-27T00:45:44Z

I uploaded the current code and thought the main skeleton was done, but still, it should have some problems that need to be fixed.
Oh, the files related to tests are not finished, so compiled could be passed. I wrote comments for some specific implementations that I am not sure about. For now, all functions under EdgeMesh have a "throw" at the beginning of the function. Please remove it before using it. Therefore, the first simple tests fail.

…wildmeshing-toolkit into hackathon/edge_mesh

daniel-zint

This is a massive PR. My main concern is that there is a lot of code of which I am not sure if it was tested. I added a few comments regarding that. Especially, if you copy code, throw an exception in every function. The fact that they look like they do something reasonable but might have not been tested is extremely dangerous. So please make sure that every function is at least called once in a test or throws an exception.

tests/test_topology.cpp

tests/test_tuple_1d.cpp

src/wmtk/EdgeMeshOperationExecutor.cpp

src/wmtk/EdgeMesh.hpp

src/wmtk/EdgeMesh.cpp

daniel-zint

Looks very good already. I am just still a bit concerned that there are functions that were implemented but never tested.

DEBUG_EdgeMesh::operator== needs to be fixed. There are a few more minor comments. I think the PR is almost there.

src/wmtk/EdgeMesh.cpp

src/wmtk/EdgeMeshOperationExecutor.hpp

tests/test_tuple_1d.cpp

tests/tools/DEBUG_EdgeMesh.cpp

daniel-zint

lgtm

daniel-zint · 2023-10-05T18:47:48Z

src/wmtk/EdgeMesh.cpp

@@ -81,8 +81,9 @@ Tuple EdgeMesh::switch_tuple(const Tuple& tuple, PrimitiveType type) const

        // TODO: This is for special case self-loop, just to make sure the local vid of the returned


Is this TODO still a TODO?

…lkit into hackathon/edge_mesh

codecov · 2023-10-09T21:54:44Z

Codecov Report

Merging #378 (e991d24) into main (cadf64c) will increase coverage by 0.48%.
The diff coverage is 89.03%.

@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   81.95%   82.43%   +0.48%     
==========================================
  Files         154      158       +4     
  Lines        4162     4470     +308     
==========================================
+ Hits         3411     3685     +274     
- Misses        751      785      +34

Flag	Coverage Δ
wildmeshing	`82.43% <89.03%> (+0.48%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
src/wmtk/MultiMeshManager.hpp	`100.00% <ø> (ø)`
src/wmtk/TriMesh.cpp	`93.04% <100.00%> (ø)`
src/wmtk/TriMeshOperationExecutor.cpp	`96.51% <ø> (ø)`
src/wmtk/attribute/ConstAccessor.hpp	`50.00% <ø> (ø)`
src/wmtk/attribute/MutableAccessor.hpp	`100.00% <ø> (ø)`
...rc/wmtk/utils/edgemesh_topology_initialization.cpp	`100.00% <100.00%> (ø)`
src/wmtk/EdgeMesh.hpp	`50.00% <50.00%> (ø)`
src/wmtk/EdgeMeshOperationExecutor.cpp	`95.20% <95.20%> (ø)`
src/wmtk/EdgeMesh.cpp	`83.66% <83.66%> (ø)`

mtao · 2023-10-11T17:19:16Z

What is left before we can merge this? I'll trust daniel's review on this, but what's left to finish off his comments?
If you're working on things that are not part of his comments this PR those changes will need to be deleted.

JcDai · 2023-10-11T17:34:55Z

What is left before we can merge this? I'll trust daniel's review on this, but what's left to finish off his comments? If you're working on things that are not part of his comments this PR those changes will need to be deleted.

I think daniel's comments are finished. There was one merge main branch to our branch after finishing the comments. I think nothing else there?

daniel-zint

Just fix that compilation issue and then let's finish this PR.

src/wmtk/EdgeMeshOperationExecutor.cpp

add dummy files

ba90699

Zhouyuan-Chen requested a review from daniel-zint September 22, 2023 02:50

Zhouyuan-Chen changed the base branch from main to hackathon/dev September 22, 2023 02:51

fixed problem

5095f98

added throws for safety

f792fb4

mtao reviewed Sep 22, 2023

View reviewed changes

src/wmtk/EdgeMesh.cpp Outdated Show resolved Hide resolved

src/wmtk/EdgeMesh.cpp Outdated Show resolved Hide resolved

mtao marked this pull request as draft September 22, 2023 19:57

mtao changed the base branch from hackathon/dev to main September 22, 2023 20:42

implemented some EdgeMesh functions

d412649

daniel-zint reviewed Sep 24, 2023

View reviewed changes

src/wmtk/Types.hpp Outdated Show resolved Hide resolved

Zhouyuan-Chen added 2 commits September 26, 2023 11:45

add EdgeMeshOperationExecutor and DEBUG_EdgeMesh

96325c6

add EdgeMesh_example and test code

b749fac

Zhouyuan-Chen and others added 3 commits September 26, 2023 21:02

fix a bug for EdgeMesh::initialize, the loop's condition wrong.

01ba6f1

Merge remote-tracking branch 'origin/main' into hackathon/edge_mesh

d9e3742

get the desired frame for edgemesh operation executor

37392a7

daniel-zint linked an issue Sep 27, 2023 that may be closed by this pull request

EdgeMesh #382

Closed

5 tasks

zlyfunction and others added 12 commits September 27, 2023 15:43

implement edgemesh split_edge

b551d2d

fimish edgemesh split_edge with return tuple

913e166

correct edgemsh split without aorientation assumptions

455c867

implement edge mesh connectivity

a75edd4

take care of the case of self loop

b6e2844

a complete draft of edge mesh operations

588530a

Merge branch 'hackathon/edge_mesh' of https://github.com/wildmeshing/…

2f50e69

…wildmeshing-toolkit into hackathon/edge_mesh

implemented edge mesh

b006e30

add 1d topology unit test

1a91445

add implementation for operations in edgemesh clas

7f9f178

fix typo

0f1e5c4

add debug_edgemesh examples

4b549e2

Leyi Zhu and others added 2 commits September 29, 2023 10:45

fix bug in split_edge ev update

add571d

finish split test

22c615a

JcDai requested review from mtao and daniel-zint October 2, 2023 14:24

JcDai marked this pull request as ready for review October 2, 2023 14:25

daniel-zint requested changes Oct 2, 2023

View reviewed changes

refactor based on comments

3844c20

JcDai requested a review from daniel-zint October 3, 2023 20:27

JcDai added 4 commits October 3, 2023 17:04

Merge remote-tracking branch 'origin/main' into hackathon/edge_mesh

57f8aae

add throw

cf18878

redo changes in TriMesh

56e6040

rollback the redo for Trimesh

d3cd444

daniel-zint reviewed Oct 4, 2023

View reviewed changes

zlyfunction added 3 commits October 4, 2023 12:13

refactor based on comments

29a6674

reuse hash acc in tests

fd11974

fix DEBUG_EdgeMesh::operator==

88f62a7

JcDai requested a review from daniel-zint October 4, 2023 16:31

daniel-zint approved these changes Oct 5, 2023

View reviewed changes

zlyfunction added 3 commits October 9, 2023 17:11

Merge branch 'main' into hackathon/edge_mesh

0409e9b

Merge branch 'main' of https://github.com/wildmeshing/wildmeshing-too…

281e5cc

…lkit into hackathon/edge_mesh

modify to fit the changes happend in main branch

6540991

typo in comment

3ee54bc

daniel-zint reviewed Oct 11, 2023

View reviewed changes

src/wmtk/EdgeMeshOperationExecutor.cpp Outdated Show resolved Hide resolved

zlyfunction added 2 commits October 11, 2023 19:22

fix compile

25251ca

delete TODO in comments

e991d24

zlyfunction merged commit 4073f06 into main Oct 12, 2023
9 checks passed

zlyfunction deleted the hackathon/edge_mesh branch October 12, 2023 16:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hackathon/edge mesh #378

Hackathon/edge mesh #378

Zhouyuan-Chen commented Sep 22, 2023 •

edited

Loading

Zhouyuan-Chen commented Sep 22, 2023 •

edited

Loading

mtao left a comment

daniel-zint left a comment

Zhouyuan-Chen commented Sep 27, 2023 •

edited

Loading

daniel-zint left a comment

daniel-zint left a comment

daniel-zint left a comment

daniel-zint Oct 5, 2023

codecov bot commented Oct 9, 2023 •

edited

Loading

mtao commented Oct 11, 2023

JcDai commented Oct 11, 2023

daniel-zint left a comment

		@@ -81,8 +81,9 @@ Tuple EdgeMesh::switch_tuple(const Tuple& tuple, PrimitiveType type) const

		// TODO: This is for special case self-loop, just to make sure the local vid of the returned

Hackathon/edge mesh #378

Hackathon/edge mesh #378

Conversation

Zhouyuan-Chen commented Sep 22, 2023 • edited Loading

Zhouyuan-Chen commented Sep 22, 2023 • edited Loading

mtao left a comment

Choose a reason for hiding this comment

daniel-zint left a comment

Choose a reason for hiding this comment

Zhouyuan-Chen commented Sep 27, 2023 • edited Loading

daniel-zint left a comment

Choose a reason for hiding this comment

daniel-zint left a comment

Choose a reason for hiding this comment

daniel-zint left a comment

Choose a reason for hiding this comment

daniel-zint Oct 5, 2023

Choose a reason for hiding this comment

codecov bot commented Oct 9, 2023 • edited Loading

Codecov Report

mtao commented Oct 11, 2023

JcDai commented Oct 11, 2023

daniel-zint left a comment

Choose a reason for hiding this comment

Zhouyuan-Chen commented Sep 22, 2023 •

edited

Loading

Zhouyuan-Chen commented Sep 22, 2023 •

edited

Loading

Zhouyuan-Chen commented Sep 27, 2023 •

edited

Loading

codecov bot commented Oct 9, 2023 •

edited

Loading