-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add legend to feature density maps #459
Comments
Based this blame which shows that line being added in #460, I assume perhaps your last recompile commit on #460 may have been against a local version of the spec that had some experimental inline defaults, i.e. legend:
label_column: "density",
color_column": "density_colormap" which were compiled against in #460 but not themselves committed? I am trying to figure out why those params are here Lines 429 to 436 in 4b0d970
but not here ecoscope-workflows/examples/events/spec.yaml Lines 147 to 155 in 4b0d970
They are being dropped by the auto-recompiles in #452, and just want to make sure that's not a mistake. I think I'm convinced its not. |
Put another way, is the above a case of us not having this ci check #433 ? |
Yep, that's 100% what happened 😅 |
This needs some thought around the display values for the legend, the
density
column alone won't be very descriptiveThe text was updated successfully, but these errors were encountered: