[WFCORE-7036] TransformationUtils.modelToResource() should not return… #6226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… undefined if possible children are not defined
This comment was marked as resolved.
This comment was marked as resolved.
|
Core -> Full Integration Build 14003 outcome was UNKNOWN using a merge of 78a22e8 |
|
Core -> WildFly Preview Integration Build 14076 outcome was UNKNOWN using a merge of 78a22e8 |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@yersan the Preview Integration Failure is definitely unrelated |
yersan
reviewed
Oct 25, 2024
Comment on lines
368
to
378
| // @Test | ||
| // public void testChildRegEmptySubsystemIsDefined() throws Exception { | ||
| // List<ModelNode> operations = new ArrayList<>(); | ||
| // operations.add(Util.createAddOperation(SUBSYSTEM_ADDR)); | ||
| // TransformationUtilsExtension.Builder builder = TransformationUtilsExtension.createBuilder(); | ||
| // builder. | ||
| // | ||
| // ModelNode model = runAndReadSubsystemModel(, operations); | ||
| // | ||
| // Assert.assertTrue(model.isDefined()); | ||
| // } |
|
Core -> Full Integration Build 14006 outcome was FAILURE using a merge of 8744c68 Failed tests |
|
Core -> WildFly Preview Integration Build 14079 outcome was FAILURE using a merge of 8744c68 Failed tests |
|
Core -> Full Integration Build 14301 outcome was FAILURE using a merge of 8744c68 Failed tests |
|
Core -> Full Integration Build 14009 outcome was FAILURE using a merge of 8744c68 Failed tests |
|
Core -> WildFly Preview Integration Build 14082 outcome was FAILURE using a merge of 8744c68 Failed tests |
|
Failures should be unrelated |
yersan
approved these changes
Oct 29, 2024
yersan
added
the
ready-for-merge
|
Thanks @kabir we plan to release it tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… undefined if possible children are not defined
https://issues.redhat.com/browse/WFCORE-7036
wildfly/wildfly#18321 must be merged first for the full integration jobs can pass.
This is needed for the transformers tests in wildfly/wildfly#18320 to pass