Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Shaded jar handling #6180

Closed
wants to merge 2 commits into from
Closed

Conversation

jfdenise
Copy link
Contributor

@wildfly-ci
Copy link

Core -> Full Integration Build 14205 outcome was FAILURE using a merge of 6e6af87
Summary: Exit code 1 (Step: Build full with JDK 17 (Maven)) Build time: 00:06:18

@wildfly-ci
Copy link

Core -> Full Integration Build 13907 outcome was FAILURE using a merge of 6e6af87
Summary: Exit code 1 (Step: Build full with JDK 17 (Maven)) Build time: 00:04:49

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 13984 outcome was FAILURE using a merge of 6e6af87
Summary: Exit code 1 (Step: Build & test full (Maven)) Build time: 00:06:12

@jfdenise
Copy link
Contributor Author

The integration tests are expected to fail. We would need to synchronize changes in WildFly that are required: wildfly/wildfly@main...jfdenise:wildfly:shaded-jar-wildfly

A custom integration (with core and full updated) CI job show that tests are passing : https://ci.wildfly.org/buildConfiguration/WF_WildFlyCoreIntegrationExperiments/457864 (The test failures are due to the wildfly-galleon-plugins being a SNAPSHOT (glow maven config has snapshot disabled). Local tests are passing).

@bstansberry , the wildfly-cli:client shaded jar is built as before, it is just not used when provisioning it in the WildFly installation. It is still referenced in the bom:

The wildfly-elytron-tool-wrapper.jar is still built but is no more a shaded jar. It only contains the classes it defines. The shaded jar is built at provisioning time.

@jfdenise
Copy link
Contributor Author

jfdenise commented Oct 9, 2024

This is superseded by #6213

@jfdenise jfdenise closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants