Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate labels in the generated script. #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alfred-stokespace
Copy link
Contributor

As mentioned whywaita/shoes-aws#2 (comment) in sister PR whywaita/shoes-aws#2

now that I'm doing full integration testing, it is clear that the script needs the labels from GH otherwise jobs won't schedule.

@whywaita
Copy link
Owner

whywaita commented Jun 6, 2024

@alfred-stokespace Sorry, my response is late.

Your suggestion is not bad. But it has a problem of security. I’m afraid of any code execution.
So, Could you add an option that “is populate labels”? myshoes will populate labels if true.

@alfred-stokespace
Copy link
Contributor Author

@alfred-stokespace Sorry, my response is late.

Your suggestion is not bad. But it has a problem of security. I’m afraid of any code execution. So, Could you add an option that “is populate labels”? myshoes will populate labels if true.

Good point! @whywaita I should have considered that. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants