Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

first script idea #72

Closed
wants to merge 6 commits into from
Closed

first script idea #72

wants to merge 6 commits into from

Conversation

Cinux90
Copy link
Contributor

@Cinux90 Cinux90 commented May 22, 2019 •
edited
Loading

resolve: #63

currently todo:

  • improve output
  • expect a empty input
  • expect unexpected input
  • some details how to start now (activate env, trigger tests etc.)
  • expect everytime keyboard interrupt
  • cleanup after work
  • help page - not needed its guided
  • check if docker is running

@while-true-do/ansible-developer: Feel free to bring ideas

@Cinux90
Copy link
Contributor Author

Cinux90 commented May 25, 2019

ok. For me the script looks ok.
Its a bit quick and dirty and not perfect but it helps with the first steps.

Feel free to review :)

@Cinux90 Cinux90 changed the title [WIP] Add: first script idea first script idea Jun 3, 2019
@Cinux90
Copy link
Contributor Author

Cinux90 commented Jun 6, 2019

@daniel-wtd feel free to review :)

dschier-wtd
dschier-wtd requested changes Jul 28, 2019
View reviewed changes
Copy link
Member

@dschier-wtd dschier-wtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cinux90 I had a review and it looks quite ok. I recommend the following steps:

  • remove the "create role stuff" -> currently it's only 2 steps
  • check with a linter like flake8
  • the ansible cfg seems to be written relative to the execution path, someone can have other stuff in there or multiple configurations and we should avoid directly manipulate such stuff. it's better to output the needed steps at the end.
  • a little bit more documentation in the code would be awesome at least each def should be documented to use some auto-doc tools in a later process
    Otherwise, cool work

@Cinux90
Copy link
Contributor Author

Cinux90 commented Jul 30, 2019

ty for review. If the weather will be colder i will have a look.. ;)

@dschier-wtd
Copy link
Member

stale for ages -> remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschier-wtd dschier-wtd dschier-wtd requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Prepare dev environment automatically
2 participants
@Cinux90 @dschier-wtd