-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trouble with providing a nonce for a Gnosis Safe transaction #4029
Comments
FYI Wagmi doesn't use |
I am convinced that connectors should work explicitly, with no ifs and no buts. In this case, the behavior is unclear and incorrect. The Safe Connector was created to interact with the Gnosis Safe Wallet. Currently, the Safe Connector does not fulfill its intended purpose and limits functionality (optional parameters are ignored). I believe it's time for Wagmi to update the safe connector and use Safe{Core} SDK because Safe Connector references a package that hasn't been updated for 5 months, and it has outdated libraries in its dependencies. Previously, the Gnosis Safe documentation contained information about safe-apps-sdk, but now it is gone (exist only in the Glossary) and the safe-apps-sdk docs link redirects to the repository. |
Let's track in the upstream issue you created. Can reach out to the Safe team to see what they recommend for packages moving forward. |
This issue has been locked since it has been closed for more than 14 days. If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Wagmi version. If you have any questions or comments you can create a new discussion thread. |
Check existing issues
Describe the bug
I need to send multiple transactions to Gnosis Safe, but Gnosis Safe does not automatically increment the nonce immediately after signing a transaction. Therefore, I need to provide the nonce manually, but Gnosis Safe ignores this argument.
However, their code specifies that the arguments should be considered: Gnosis Safe code.
Link to Minimal Reproducible Example
code: https://github.com/Pasha8914/wagmi-safe-bug
preview: https://pasha8914.github.io/wagmi-safe-bug
Steps to Reproduce the Issue
OR
You will observe that the first and second transactions have the same nonce, although different nonces were provided.
What Wagmi package(s) are you using?
wagmi, @wagmi/connectors, @wagmi/core, create-wagmi
Wagmi Version
wagmi-2.9.10
Viem Version
2.13.7
TypeScript Version
5.2.2
Anything else?
Screen.Recording.2024-06-11.at.00.mp4
The text was updated successfully, but these errors were encountered: