Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove {slug} from contracts #37

Open
olf42 opened this issue Oct 16, 2019 · 3 comments
Open

Remove {slug} from contracts #37

olf42 opened this issue Oct 16, 2019 · 3 comments
Labels
enhancement New feature or request
Milestone
Version 1.0

Comments

@olf42
Copy link
Member

olf42 commented Oct 16, 2019

Contracts have a unique identifier (cid) and can be identified better by giving the name or email address of the other party. Therefore I propose to remove the slug property from the contracts.
@olf42 olf42 added the enhancement New feature or request label Oct 16, 2019
@olf42 olf42 added this to the Version 1.0 milestone Oct 16, 2019
@olf42
Copy link
Member Author

olf42 commented Oct 16, 2019

Furthermore: If no slug is set, print-contracts will print unknown. If this is a property used to distiguish contracts in this view, a different property should be used.

@aparcar
Copy link
Collaborator

aparcar commented Oct 16, 2019

I like the idea of having a slug or nick which is easier to remember than a long number...

@olf42
Copy link
Member Author

olf42 commented Oct 17, 2019

Good point.
How do we ensure that it's unique?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 1.0
Development

No branches or pull requests
2 participants
@olf42 @aparcar