Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid % string interpolation #33

Closed
sobolevn opened this issue Jul 3, 2018 · 0 comments
Closed

Forbid % string interpolation #33

sobolevn opened this issue Jul 3, 2018 · 0 comments
Labels
help wanted Extra attention is needed level:starter Good for newcomers rule request Adding a new rule

Comments

@sobolevn
Copy link
Member

sobolevn commented Jul 3, 2018

As we have decided to stick to .format(), we are banning f strings: #32

But, @vergeev have also suggested to forbid 'string with %s' % some.
Here's the backstory:

So, this would be valid:

some_variable % 'value1'
5 % 2

This would be invalid:

'format me %s' % 'value2'
@sobolevn sobolevn added rule request Adding a new rule help wanted Extra attention is needed level:starter Good for newcomers labels Jul 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed level:starter Good for newcomers rule request Adding a new rule
Projects
None yet
Development

No branches or pull requests

1 participant