Drops unnecessary dependency on yarn in favor of npm, always available. #33
Conversation
|
I don't understand your fix. The fix should be adding the implicit dependencies as devDependencies, but you're not doing that. As of this instance, this works with yarn, and not with npm, so unless you fix this precise issue, this PR can't be merged. |
|
Adding Yarn to the Contrary to what its name indicates the However, while Npm users will probably not be aware of the lock-file issue and this dismiss it, Yarn users probably would and, if any issue arises on installation, they might easily fix it by falling back to Npm since everyone has Npm while non-Yarn users would simply be stuck. The full solution would be to provide both yarn and npm lock files as suggested in this comment within a long standing conversation about this issue. Anyway, in-house usage and world-wide adoption require two different criteria and, whatever your internal preferences, Npm is best for the wider audience. None of this affects library users, just contributors. |
To make wider distribution easier, once downloaded, it is good manners that a package should not fail on the
npm icommand.Making implicit dependencies on globally installed packages (thus not present in the dependencies lists of
package.json) is not a good idea, specially when there is no real need.Partially fixes #30