Upgrade husky
#11323
Closed
Upgrade husky
#11323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcantin-w
commented
Oct 23, 2024
| @@ -18,7 +18,6 @@ | |||
| "@storybook/react": "^8.3.5", | |||
| "@storybook/theming": "^8.3.5", | |||
| "chromatic": "^6.21.1", | |||
| "husky": "^4.3.0", | |||
There was a problem hiding this comment.
Was not used in here?
|
Size Change: -12 B (0%) Total Size: 982 kB
ℹ️ View Unchanged
|
I can't get this to work on this branch, but if I do the same on main it does work. |
Open
|
I've created a new ticket for this to re-do when I have time, will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Upgrades
huskyto its latest version (5 major versions up!) and change config as per new set-up rules.How to test
Run locally, run
yarnand make a change to a file that will upseteslint, then try to commit that change. You should be stopped at the pre-commit stage.How can we measure success?
Latest versions yo. Seems to also remove a ton of dependencies?
Have we considered potential risks?
N/A