Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible dataset class, or overide to allow multiple geometries #842

Open
bw4sz opened this issue Dec 2, 2024 · 1 comment
Open
Labels
API This tag is used for small improvements to the readability and usability of the python API.

Comments

@bw4sz
Copy link
Collaborator

bw4sz commented Dec 2, 2024

As DeepForest moves to 2.0 and support for boxes/polygons/points, we need to wary of places that are hardcoded for just boxes. One spot is in the dataset.TreeDataset class, which assumes boxes and even names the target key {"boxes":}

It connects here:

ds = dataset.TreeDataset(csv_file=csv_file,

Option 1. A master dataset class that works by detecting the geometry.

Option 2. Allow users to pass a dataset class

@bw4sz bw4sz added the API This tag is used for small improvements to the readability and usability of the python API. label Dec 2, 2024
@bw4sz bw4sz added this to the DeepForest 2.0 milestone Dec 2, 2024
@bw4sz
Copy link
Collaborator Author

bw4sz commented Dec 2, 2024

Related to #833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API This tag is used for small improvements to the readability and usability of the python API.
Projects
None yet
Development

No branches or pull requests

1 participant