Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated main.deepforest.predict_file for DF usage #852

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

updated main.deepforest.predict_file for DF usage #852

wants to merge 3 commits into from

Conversation

naxatra2
Copy link

Fixes #797

In the main.deepforest.predict_file should now also be able to take in a dataframe, not just a csv file.
There was another PR open (PR #838) for similar issue but it wasn't working so I improved it.

@naxatra2
Copy link
Author

Its clearing all the tests in local environment. I don't know why its not showing in github

@ethanwhite
Copy link
Member

Its clearing all the tests in local environment. I don't know why its not showing in github

That is weird. Can you try either opening a new PR from the same branch or pushing a tiny change to a comment to see if it will trigger the build (or ask us to trigger it).

@ethanwhite
Copy link
Member

That did it. I think there was just hiccup with the prompt asking us to allow the tests to run (since you're a new contributor). The build failure is something that just cropped up with an image change. Hopefully #855 will fix that and then we can rerun

@naxatra2
Copy link
Author

Okay. I was very confused as to what went wrong. This certainly helps.

@ethanwhite
Copy link
Member

@naxatra2 - If you rebase this on main the tests should run now

@naxatra2
Copy link
Author

Is this good ?

@ethanwhite
Copy link
Member

Thanks @naxatra2 - tests are passing now. We'll try to review the PR next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrykironde henrykironde Awaiting requested review from henrykironde

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

main.deepforest.predict_file should be able to take in a dataframe, not just a csv file.
2 participants
@naxatra2 @ethanwhite