Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent submitting invalid regex with keyboard enter #2228

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: Prevent submitting invalid regex with keyboard enter #2228

merged 1 commit into from
Dec 10, 2024

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Dec 10, 2024

Fixes #2227

Manual testing

  1. Log in as crawler
  2. Start a crawl
  3. Go to watch crawl
  4. Open exclusion editor
  5. Choose "Regex" type
  6. Type in invalid regex like **
  7. Hit "Enter" on keyboard. Verify regex is not submitted

@SuaYoo SuaYoo requested a review from ikreymer December 10, 2024 02:11
@ikreymer ikreymer merged commit 541298e into main Dec 10, 2024
2 checks passed
@ikreymer ikreymer deleted the frontend-fix-invalid-regex-submission branch December 10, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikreymer ikreymer Awaiting requested review from ikreymer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Able to submit invalid regex exclusion
2 participants
@SuaYoo @ikreymer