wip: Track public collection events #2256
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
frontend-thumbnails-start-page
to
public-collections-feature
December 23, 2024 20:38
SuaYoo
force-pushed
the
public-collections-feature
branch
from
ff11634 to
6f2d7bb
Compare
SuaYoo
force-pushed
the
frontend-thumbnails-start-page--tracking
branch
from
a8f54c6 to
b27218d
Compare
emma-sg
reviewed
Dec 23, 2024
Comment on lines
+223
to
+224
|
|
||
| window.analytics = window.plausible || function () { (window.plausible.q = window.plausible.q || []).push(arguments); }; |
There was a problem hiding this comment.
I don't think this is necessary: this only helps track 404 pages, and is an optional addition to Plausible's tracking script; and it also needs to follow the Plausible script itself, so it'd also need to be added to a new script tag and inserted after the main Plausible one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2224
Changes
Manual testing
Screenshots