Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Collection thumbnails, start page, and public view updates #2209

Merged
merged 43 commits into from
Dec 23, 2024

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Dec 4, 2024

Changes

Manual testing

(The manual testing steps are left deliberately vague to test the usability of this feature. Open to any UX related feedback.)

Backend must be deployed locally using this branch: #2198

Log in as crawler to public org. Verify the following:

  • Update and view collection summary and description
  • Enable and disable download button on unlisted/public collection page
  • Change the collection's default thumbnail in "Share Settings"
  • Choose a Replay home URL and optionally set the thumbnail to the URL preview
  • Browse public collection starting from its home URL
  • Public collections display correctly on smaller screen sizes

Screenshots

Page Image/video
Org Dashboard No public collections:
Screenshot 2024-12-17 at 11 24 52 AM
Collections Action menu:
Screenshot 2024-12-17 at 11 41 11 AM
Collections New collection dialog:
Screenshot 2024-12-17 at 12 03 36 PM
Collection Detail Edit about:
Screenshot 2024-12-17 at 11 33 49 AM
Collection Detail Action. menu:
Screenshot 2024-12-17 at 11 34 33 AM
Collection Detail Configure replay home dialog:
Screenshot 2024-12-17 at 11 34 49 AM

Screenshot 2024-12-17 at 11 34 57 AM

Screenshot 2024-12-17 at 11 35 14 AM
Collection Detail Choose thumbnail:
Screenshot 2024-12-17 at 4 28 54 PM
Dashboard With public collections:
Screenshot 2024-12-17 at 11 46 54 AM
Public Org Profile Screenshot 2024-12-17 at 11 54 00 AM
Public Collection Replay with home URL:
Screenshot 2024-12-17 at 11 35 41 AM
Public Collection About:
Screenshot 2024-12-17 at 11 35 56 AM
Public Collection No description provided:
Screenshot 2024-12-17 at 11 33 33 AM

@SuaYoo SuaYoo changed the base branch from main to public-collections-feature December 4, 2024 04:13
@SuaYoo SuaYoo force-pushed the public-collections-feature branch from d6f4549 to b7f8ac1 Compare December 9, 2024 16:58
@SuaYoo SuaYoo force-pushed the frontend-thumbnails-start-page branch 2 times, most recently from c6b7ffb to 12e262a Compare December 9, 2024 19:27
@SuaYoo SuaYoo force-pushed the public-collections-feature branch from b7f8ac1 to c7f827c Compare December 10, 2024 01:46
@SuaYoo SuaYoo force-pushed the frontend-thumbnails-start-page branch from ed8f061 to eb75685 Compare December 10, 2024 01:56
@SuaYoo SuaYoo force-pushed the public-collections-feature branch from c7f827c to 323070b Compare December 11, 2024 00:32
@SuaYoo SuaYoo force-pushed the frontend-thumbnails-start-page branch from 1a8839e to 68d2a2a Compare December 11, 2024 00:33
@SuaYoo SuaYoo force-pushed the public-collections-feature branch from 323070b to efc3e1d Compare December 16, 2024 17:33
@SuaYoo SuaYoo force-pushed the frontend-thumbnails-start-page branch 2 times, most recently from 317556d to 37c458a Compare December 16, 2024 17:55
@SuaYoo SuaYoo force-pushed the public-collections-feature branch from efc3e1d to 76daafb Compare December 17, 2024 17:31
emma-sg

This comment was marked as resolved.

@SuaYoo

This comment was marked as resolved.

emma-sg

This comment was marked as resolved.

@SuaYoo

This comment was marked as resolved.

@SuaYoo

This comment was marked as resolved.

@emma-sg

This comment was marked as resolved.

@SuaYoo SuaYoo requested a review from emma-sg December 17, 2024 23:07
@SuaYoo
Copy link
Member Author

SuaYoo commented Dec 18, 2024

@tw4l @emma-sg I went ahead and merged in the public download button changes into this PR as well. This also included some tweaks to move the share dialog content to tabs:

Screenshot 2024-12-17 at 4 28 54 PM

When enabled, the download link should show in the "Copy Link" split menu.

I'm definitely open to suggestions on how to accurately convey download access:

Screenshot 2024-12-17 at 4 29 14 PM

@tw4l

This comment was marked as resolved.

Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done a bunch of testing, not finding any other issues. Great work!

Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking and working great!

@SuaYoo SuaYoo merged commit ff11634 into public-collections-feature Dec 23, 2024
2 checks passed
@SuaYoo SuaYoo deleted the frontend-thumbnails-start-page branch December 23, 2024 20:38
SuaYoo added a commit that referenced this pull request Dec 23, 2024
- Allows user to choose collection replay home page and collection
thumbnail (resolves
#2182)
- Displays collection thumbnails on org dashboard and public page
- Enables downloading public collection (resolves
#2233)
- Adds caption as "Summary" to metadata dialog
- Moves description editor to "About" tab

---------

Co-authored-by: Emma Segal-Grossman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List collection thumbnails and configure home page URL
3 participants