Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: No error on "Page URL" without protocol #2165

Closed
SuaYoo opened this issue Nov 19, 2024 · 1 comment
Closed

[Bug]: No error on "Page URL" without protocol #2165

SuaYoo opened this issue Nov 19, 2024 · 1 comment
Assignees
@SuaYoo
Labels
bug Something isn't working front end Requires front end dev work

Comments

@SuaYoo
Copy link
Member

SuaYoo commented Nov 19, 2024

Browsertrix Version

v1.12.1-e0a93fc

What did you expect to happen? What happened instead?

The frontend doesn't show an error when a URL is entered without http/https. The backend does return an error, but it isn't visible.

Reproduction instructions

  1. Log in as crawler
  2. Go to new Crawl Workflow
  3. Choose Single Page scope
  4. Enter www.example.com
  5. Click "Review & Save"
  6. Click "Save Workflow". The workflow isn't saved, and the server error isn't visible

Screenshots / Video

No response

Environment

No response

Additional details

Originally reported by @dcgomes. There are a few issues here:

  1. The backend server message isn't visible until the page is all the way scrolled down
  2. The frontend treats www.domain.com as a valid URL while the backend does not. The frontend correctly shows an error for a string without www..

We can probably get away automatically appending https if it's omited.
@SuaYoo SuaYoo added the bug Something isn't working label Nov 19, 2024
@SuaYoo SuaYoo self-assigned this Nov 19, 2024
@ikreymer ikreymer moved this from Triage to Todo in Webrecorder Projects Nov 19, 2024
@SuaYoo SuaYoo added the front end Requires front end dev work label Nov 19, 2024
@SuaYoo SuaYoo mentioned this issue Nov 21, 2024
Open
@SuaYoo
Copy link
Member Author

SuaYoo commented Nov 26, 2024

Should be addressed by #2167 and #2169

@SuaYoo SuaYoo closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done! in Webrecorder Projects Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SuaYoo SuaYoo

Labels
bug Something isn't working front end Requires front end dev work
Projects
Webrecorder Projects
Status: Done!
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SuaYoo