Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes to collections to support publicly listed collections #2164

Merged
merged 11 commits into from
Nov 22, 2024

Conversation

tw4l
Copy link
Member

@tw4l tw4l commented Nov 19, 2024

Fixes #2158

  • Adds Organization.listPublicCollections field and API endpoint to update it
  • Replaces Collection.isPublic boolean with Collection.access (values: private, unlisted, public) and add database migration
  • Update frontend to use Collection.access instead of isPublic, otherwise not changing current behavior

@SuaYoo
Copy link
Member

SuaYoo commented Nov 19, 2024

Sweet, thanks for the frontend changes! Pushed an update to use an enum: dd58043

Copy link
Member

@SuaYoo SuaYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend LGTM!

@SuaYoo SuaYoo force-pushed the issue-2158-public-org-backend branch from b21f876 to 4ebf86f Compare November 19, 2024 22:25
@tw4l tw4l force-pushed the issue-2158-public-org-backend branch from 4ebf86f to 88069ac Compare November 19, 2024 22:33
@SuaYoo
Copy link
Member

SuaYoo commented Nov 21, 2024

@tw4l Should we create a new feature branch to push all public collections work?

@tw4l tw4l changed the base branch from main to public-collections-feature November 22, 2024 15:33
@tw4l
Copy link
Member Author

tw4l commented Nov 22, 2024

@tw4l Should we create a new feature branch to push all public collections work?

@SuaYoo Great idea! Created public-collections-feature and changed that to the base for this PR. I'm going to merge this into that feature branch after a bit more testing this morning so that you have something to work from, and we can have Ilya review the backend when we go to merge the feature branch into main.

@tw4l tw4l merged commit 824b84f into public-collections-feature Nov 22, 2024
6 checks passed
@tw4l tw4l deleted the issue-2158-public-org-backend branch November 22, 2024 16:47
@tw4l tw4l restored the issue-2158-public-org-backend branch November 27, 2024 15:35
SuaYoo added a commit that referenced this pull request Nov 27, 2024
…2164)

Fixes #2158 

- Adds `Organization.listPublicCollections` field and API endpoint to
update it
- Replaces `Collection.isPublic` boolean with `Collection.access`
(values: `private`, `unlisted`, `public`) and add database migration
- Update frontend to use `Collection.access` instead of `isPublic`,
otherwise not changing current behavior

---------

Co-authored-by: sua yoo <[email protected]>
tw4l added a commit that referenced this pull request Nov 27, 2024
…2164)

Fixes #2158 

- Adds `Organization.listPublicCollections` field and API endpoint to
update it
- Replaces `Collection.isPublic` boolean with `Collection.access`
(values: `private`, `unlisted`, `public`) and add database migration
- Update frontend to use `Collection.access` instead of `isPublic`,
otherwise not changing current behavior

---------

Co-authored-by: sua yoo <[email protected]>
SuaYoo added a commit that referenced this pull request Nov 28, 2024
…2164)

Fixes #2158 

- Adds `Organization.listPublicCollections` field and API endpoint to
update it
- Replaces `Collection.isPublic` boolean with `Collection.access`
(values: `private`, `unlisted`, `public`) and add database migration
- Update frontend to use `Collection.access` instead of `isPublic`,
otherwise not changing current behavior

---------

Co-authored-by: sua yoo <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 4, 2024
…2164)

Fixes #2158 

- Adds `Organization.listPublicCollections` field and API endpoint to
update it
- Replaces `Collection.isPublic` boolean with `Collection.access`
(values: `private`, `unlisted`, `public`) and add database migration
- Update frontend to use `Collection.access` instead of `isPublic`,
otherwise not changing current behavior

---------

Co-authored-by: sua yoo <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 9, 2024
…2164)

Fixes #2158 

- Adds `Organization.listPublicCollections` field and API endpoint to
update it
- Replaces `Collection.isPublic` boolean with `Collection.access`
(values: `private`, `unlisted`, `public`) and add database migration
- Update frontend to use `Collection.access` instead of `isPublic`,
otherwise not changing current behavior

---------

Co-authored-by: sua yoo <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 10, 2024
…2164)

Fixes #2158 

- Adds `Organization.listPublicCollections` field and API endpoint to
update it
- Replaces `Collection.isPublic` boolean with `Collection.access`
(values: `private`, `unlisted`, `public`) and add database migration
- Update frontend to use `Collection.access` instead of `isPublic`,
otherwise not changing current behavior

---------

Co-authored-by: sua yoo <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 11, 2024
…2164)

Fixes #2158 

- Adds `Organization.listPublicCollections` field and API endpoint to
update it
- Replaces `Collection.isPublic` boolean with `Collection.access`
(values: `private`, `unlisted`, `public`) and add database migration
- Update frontend to use `Collection.access` instead of `isPublic`,
otherwise not changing current behavior

---------

Co-authored-by: sua yoo <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 16, 2024
…2164)

Fixes #2158 

- Adds `Organization.listPublicCollections` field and API endpoint to
update it
- Replaces `Collection.isPublic` boolean with `Collection.access`
(values: `private`, `unlisted`, `public`) and add database migration
- Update frontend to use `Collection.access` instead of `isPublic`,
otherwise not changing current behavior

---------

Co-authored-by: sua yoo <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 17, 2024
…2164)

Fixes #2158 

- Adds `Organization.listPublicCollections` field and API endpoint to
update it
- Replaces `Collection.isPublic` boolean with `Collection.access`
(values: `private`, `unlisted`, `public`) and add database migration
- Update frontend to use `Collection.access` instead of `isPublic`,
otherwise not changing current behavior

---------

Co-authored-by: sua yoo <[email protected]>
SuaYoo added a commit that referenced this pull request Dec 23, 2024
…2164)

Fixes #2158 

- Adds `Organization.listPublicCollections` field and API endpoint to
update it
- Replaces `Collection.isPublic` boolean with `Collection.access`
(values: `private`, `unlisted`, `public`) and add database migration
- Update frontend to use `Collection.access` instead of `isPublic`,
otherwise not changing current behavior

---------

Co-authored-by: sua yoo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API updates for public collections
2 participants