Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: allow bundle content retrieval to be customized in parseBundle #217

Closed
wants to merge 1 commit into from
Closed

Proposal: allow bundle content retrieval to be customized in parseBundle #217

wants to merge 1 commit into from

Conversation

andrewbranch
Copy link

I'm looking to use some parts of this project in a scenario where it's easiest to retrieve bundle files from a CDN rather than from the file system itself. I could download from the CDN to a temporary location, but by abstracting the fs calls to a “bundle host” object, I can feed the function a string from memory rather than relying on the file system itself. It would be even nicer if this function were async, and I could just tell the bundleHost to fetch() from the CDN, but I figured adding that complexity wouldn’t be warranted here.

At the moment, I only need parseBundle, and so only made changes there, but this approach could be used throughout the project, and I'd be open to making those changes if that would make this PR seem more appealing.

Thoughts? Thanks for this project and for the consideration!

@jsf-clabot
Copy link

jsf-clabot commented Oct 21, 2018

CLA assistant check
All committers have signed the CLA.

@andrewbranch
Copy link
Author

Glancing through the issues, this seems tangentially related to #32, since my goal in making this change is to use some of the analyzer code without the UI.

@andrewbranch
Copy link
Author

Cleaning up some loose ends this morning, going to close this one out. I no longer need this change and it seems like no one else does either. If there's interest in the future feel free to resurrect this code and use it. Cheers! 👋🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants