Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Idea] Integrate "WAR - WebOS Ad Removal" into the homebrew channel #76

Open
gorshco opened this issue Oct 2, 2022 · 2 comments
Open

Comments

@gorshco
Copy link

gorshco commented Oct 2, 2022

Repo:
https://github.com/bashalarmist/war-webos-ad-remover

This would be ideal as a toggle, to enable/disable the script's execution on boot.

@TimMods
Copy link

TimMods commented Oct 31, 2022

I wouldn't suggest integrating this to the homebrew channel.
My idea is to just add an uninstall button in the homebrew channel for hidden/non-frontend apps/scripts.

Or perhaps even a non packaged format to easily support scripts only.

webosbrew/webos-homebrew-channel#101

@Simon34545
Copy link
Contributor

The problem is, not all WebOS versions are supported by this script.

On my tv, which is WebOS 4.4.1-1004, there is no home screen app (it's the overlay style home screen), so /usr/palm/applications/com.webos.app.home/ does not exist.

You might have to check for the existence of the required files first and give a warning if they don't exist.
# These are the source files that we will copy and modify. WAR_AI_BOARD_SOURCE="/usr/palm/applications/com.webos.app.home/qml/UserInterfaceLayer/Containers/Main/AIBoard.qml" WAR_RECOMMENDED_SOURCE="/usr/palm/applications/com.webos.app.home/qml/UserInterfaceLayer/Containers/Main/Recommended.qml"

On top of that, those files have some modifications across versions, so you would also have to check the sha512 sum of each file before enabling the option.

WAR_AI_BOARD_SUM="986fb371dd6a8edf5a5fa8479076011c2ad0375533c8aed997cf2d50254737d34b524732d745eafff5294c37bbf5b16d57c5f03b88d547d81eb0c18beb9d01e5 /usr/palm/applications/com.webos.app.home/qml/UserInterfaceLayer/Containers/Main/AIBoard.qml" WAR_RECOMMENDED_SUM="1f41b67dc3603908c3aece24c9eae6798684f92cbc89ebd4594e0d786a90dddd9aa0c1c84b9a6142f07deb955dbbd5afbe1c6fef6ca29618267caa0920872e16 /usr/palm/applications/com.webos.app.home/qml/UserInterfaceLayer/Containers/Main/Recommended.qml"

@Informatic Informatic transferred this issue from webosbrew/webos-homebrew-channel Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants