Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance favicon support #206

Open
benfrancis opened this issue Sep 6, 2019 · 0 comments
Open

Enhance favicon support #206

benfrancis opened this issue Sep 6, 2019 · 0 comments
Labels

Comments

@benfrancis
Copy link
Member

Currently Shell just uses the first icon in the list provided in the page-favicon-updated event by Electron. This is because Electron only provides an array of URLs without any additional metadata to choose between them. The first icon may not necessarily be the best size and type to display, or even be a supported image format.

Enhancing this function requires modifying Electron, or possibly Chromium. See electron/electron#14803

@benfrancis benfrancis added the task label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant