WebNN: Define mojo and IDL for constant (fillSequence) operator #45195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5378104
branch
4 times, most recently
from
92b2766
to
9d42d76
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5378104
branch
3 times, most recently
from
cd4f246
to
6b0ef04
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5378104
branch
2 times, most recently
from
6b104ef
to
38e499c
Compare
According to the WebNN spec[1], this CL defines mojo and extends the IDL definition of constant MLOperand which can be created with the specified data type and shape that contains the data as specified by the range. Some related WPT tests and services unit tests are also added. Since "bigint" currently has extremely limited use in Chromium, binding code generation cannot yet handle unions with it[2]. We currently support all data types supported by WebNN except int64 and uint64. [1]: https://www.w3.org/TR/webnn/#api-mlgraphbuilder-constant-range [2]: whatwg/webidl#1388 Bug: 40206287, 328109810 Change-Id: Iae0212071fc3567cebeeb8abb306b1d3b81ca462
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5378104
branch
from
38e499c
to
6110340
Compare
|
Close this PR because the Chromium CL has been abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the WebNN spec1, this CL defines mojo and extends the IDL
definition of constant MLOperand which can be created with the specified
data type and shape that contains the data as specified by the range.
Some related WPT tests and services unit tests are also added.
Since "bigint" currently has extremely limited use in Chromium, binding
code generation cannot yet handle unions with it2. We currently
support all data types supported by WebNN except int64 and uint64.
Bug: 40206287, 328109810
Change-Id: Iae0212071fc3567cebeeb8abb306b1d3b81ca462
Reviewed-on: https://chromium-review.googlesource.com/5378104
WPT-Export-Revision: b8b7ad109f571d805481fc29d85ededdb4501b9d