Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want "aquarium-direct-map" any more? #196

Open
hujiajie opened this issue Apr 1, 2021 · 1 comment
Open

Do we want "aquarium-direct-map" any more? #196

hujiajie opened this issue Apr 1, 2021 · 1 comment

Comments

@hujiajie
Copy link
Collaborator

hujiajie commented Apr 1, 2021

I have mixed feeling about dropping //src/aquarium-direct-map.

Pros

  • Our maintenance effort can be reduced.

Cons

  • It can work as a perf baseline to tell whether abstraction in the "optimized" variant is over-engineered.
  • If we prefer to remove it, further discussion about the new directory hierarchy is needed. For example, //src/aquarium-optimized/* can be moved to //src/*, and //src/common seems no longer necessary as well.
  • The overall maintenance effort probably won't be reduced much. Usually the difficult part is to come up with a design out of thin air, instead of mirroring the change from one directory to the other.
@hujiajie
Copy link
Collaborator Author

hujiajie commented Apr 9, 2021

The decision is to remove aquarium-direct-map.

@hujiajie hujiajie closed this as completed Apr 9, 2021
@hujiajie hujiajie reopened this Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant