Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification for only installed Profiles #1337

Closed
Skarlso opened this issue Jan 24, 2022 · 1 comment
Closed

Notification for only installed Profiles #1337

Skarlso opened this issue Jan 24, 2022 · 1 comment

Comments

@Skarlso
Copy link
Contributor

Skarlso commented Jan 24, 2022

Short description

As a user I want to only be notified for new versions for installed profiles so that I don't became overwhelmed with notification that I'm not interested in.

Right now regarding #1143 and the PR #1317 we are sending notification for all profiles regardless of their status regarding to the cluster.

However, detecting if a profile is installed is not trivial. Questions are where is it installed? In this cluster? In a repo? In any of the other clusters?

A potential other solutions is defining fine grained filters which a user could set to avoid getting notified for a specific profile which would help in certain cases, like not caring if it's installed or not.

Acceptance criteria

  • notifications can be filtered with either a filter or by detecting installed status
@Skarlso
Copy link
Contributor Author

Skarlso commented Feb 8, 2022

Now it's possible after #1360 has been done. An installed profile into a cluster can be detected by looking for a specific HelmRelease with namespace, name, profiles name and version.

@JamWils JamWils closed this as completed Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants