Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zaakbrug should check both eindDatum and eindStatus when closing a zaak #292

Open
mericakgul opened this issue Mar 22, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@mericakgul
Copy link
Collaborator

mericakgul commented Mar 22, 2024

We are having error in the following scenarios and the zaak closure doesn't happen. However the zaak closure should proceed.

The scenario: We have a zaak with a zaaktype which has a dummy resultaat value for only endCaseEndDate in profile.json file. This zaak doesn't have a resultaat and we send an updateZaak request which has both eindDatum and eindStatus.

Current behaviour: Zaakbrug starts closure process first with eindStatus. To be able to close a zaak (which doesn't have a resultaat) with eindStatus we need to have a dummy resultaat under endDateAndResultLastStatus in profile.json. However, in this case we don't have endDateAndResultLastStatus but we have endCaseEndDate in profile.json. Therefore, zaakbrug immediately throws an error without continueing the closure process with eindDatum.

Desired behaviour: Zaaakbrug should continue the process by using the values of eindDatum and dummy resultaat value under endCaseEndDate and close the zaak. Normally when we close a zaak by using eindDatum the time value of 'datumStatusGezet' field of status is set zero, however, we already have datumStatusGezet value in our updateZaak request because we bot h have eindDatum and eindStatus information in the request. Therefore, we could also set datumStatusGezet value by using eindStatus in updateZaak instead of setting the time zero.

Note: After fixing, also check the related test cases and update the assertions accordingly.

@MLenterman MLenterman added the bug Something isn't working label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants